fix: preserve .tail text when removing empty elements (#1938)#1939
Merged
fix: preserve .tail text when removing empty elements (#1938)#1939
Conversation
remove_empty_elements_fast() was dropping trailing text attached to elements via lxml .tail when removing empty elements. Now appends the tail to the previous sibling or parent before removal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remove_empty_elements_fast()drops trailing text when removing empty elements with non-empty .tail #1938:remove_empty_elements_fast()was dropping trailing text (lxml.tail) when removing empty elements. For example, on arxiv.org pages, the abstract gets truncated because empty elements left by overlay removal carry.tailtext that is silently discarded..tailto the previous sibling's.tailor the parent's.text.Test plan
<span>with.tailtext — tail now preserved<b>between paragraphs — connector text preserved